-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors should consistently include filename, line number, and column number #1277
Comments
I try to work up to this since that might already be useful for me. |
@BeatScherrer Nice! I'd start with tests, add those, and then work from there. You can even open a draft PR with the failing tests, to confirm that they look good. |
What about allowing a message in case of failure? Something like python's assert
I don't know what sintax to suggest, but maybe something like:
|
Fixed in #1737. |
That's really cool to see. I tried to work on this but got lost on how to implement it in the best way since I'm neither familiar with the just code base nor a proficient rust developer. |
I'd like to copy Rust's error messages, and have a line after the error message that starts with a
-->
and includes the filename, line number, and column number. So this error:From this justfile:
Should look like this:
This would allow tools to easily extract the error information and jump to the right place in the justfile.
Also, this would make the transition to any kind of multi-justfile world (e.g. includes, modules, etc) much easier, since we would already have the functionality for printing out the filename.
The text was updated successfully, but these errors were encountered: