fix: avoid raising exception in remove_grouping_policy

[cs1137195420]

Fix: #250

[CLAassistant]

All committers have signed the CLA.

[casbin-bot]

@ffyuanda @Zxilly @elfisworking please review

[hsluoyz]

@leeqvip @tangyang9464 @abichinger @Abingcbc plz review

[abichinger]

@cs1137195420 Did you mean to link to #258?

[cs1137195420]

@cs1137195420 Did you mean to link to #258?

No, this branch is created for #250.

[abichinger]

@cs1137195420 Whoops, my bad

remove_grouping_policies still raises the same error if a non-existent link is removed.
In my opinion, we souldn't raise an exception in delete_link

[cs1137195420]

@cs1137195420 Whoops, my bad

remove_grouping_policies still raises the same error if a non-existent link is removed. In my opinion, we souldn't raise an exception in delete_link

I agree with you. Maybe we could replace raise statement with return statement in delete_link.

[abichinger]

LGTM! 👍

[hsluoyz]

@leeqvip @tangyang9464 plz review

[tangyang9464]

@cs1137195420 plz modify your PR title and commit message to make them semantic instead of fix issue, confusing.

[cs1137195420]

@cs1137195420 plz modify your PR title and commit message to make them semantic instead of fix issue, confusing.

Thanks for the reminder, I have revised the PR title. Does the current PR title fix: avoid raising exception in remove_grouping_policy meet your requirements?

[tangyang9464]

@cs1137195420 plz modify your PR title and commit message to make them semantic instead of fix issue, confusing.

Thanks for the reminder, I have revised the PR title. Does the current PR title fix: avoid raising exception in remove_grouping_policy meet your requirements?

@cs1137195420 It's ok.

[tangyang9464]

lgtm

[github-actions]

🎉 This PR is included in version 1.16.4 🎉

The release is available on:

• v1.16.4
• GitHub release

Your semantic-release bot 📦🚀