Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subjectPriority #187

Closed
leeqvip opened this issue Sep 8, 2021 · 12 comments · Fixed by #231
Closed

Implement subjectPriority #187

leeqvip opened this issue Sep 8, 2021 · 12 comments · Fixed by #231
Assignees
Labels
enhancement New feature or request

Comments

@leeqvip
Copy link
Member

leeqvip commented Sep 8, 2021

@ffyuanda

@casbin-bot
Copy link
Member

@ffyuanda @Zxilly

@casbin-bot casbin-bot added the question Further information is requested label Sep 8, 2021
@leeqvip leeqvip added enhancement New feature or request and removed question Further information is requested labels Sep 8, 2021
@ffyuanda
Copy link
Member

ffyuanda commented Sep 8, 2021

will do

@hsluoyz
Copy link
Member

hsluoyz commented Sep 8, 2021

@MRGUOKING plz fix the label inaccuracy:

image

@ffyuanda
Copy link
Member

ffyuanda commented Sep 16, 2021

since we don't have priority (explicit) support in model yet, I will do this one first
casbin/casbin@49b7fe8#diff-a5ce247e55d5a20707517e34bef620f2eb369b4f9b8fa44fdfb2c18a702418e8

subjectPriority will come later

@hsluoyz
Copy link
Member

hsluoyz commented Nov 21, 2021

@sallycaoyu @Abingcbc we can work on this as next step

@Abingcbc
Copy link
Member

@hsluoyz What should we do besides this subjectPriority https://github.com/casbin/pycasbin/blob/master/casbin/effect/__init__.py#L19 ?

@hsluoyz
Copy link
Member

hsluoyz commented Nov 21, 2021

@techoner any advice for Abingcbc?

@sallycaoyu
Copy link
Contributor

sallycaoyu commented Nov 21, 2021

Seems like we need to implement the subjectPriority model for PyCasbin from scratch?
Link to an example of subjectPriority: https://casbin.org/docs/en/supported-models#examples

Is it a good approach if we start by looking at how it has been implemented in other Casbin repos?
https://github.com/casbin/casbin/search?q=subjectPriority&type=code

Please give us more advice on this, thank you!

@Zxilly
Copy link
Contributor

Zxilly commented Nov 21, 2021

@sallycaoyu Casbin-go implement this model. You can refer to that.
But casbin-go and casbin-python have different effector implementation. You may need additional work to implement it.

@sallycaoyu
Copy link
Contributor

@Zxilly Thanks for the advice! I'll take a look at the effector first.

@timabilov
Copy link
Contributor

  • for this feature

@hsluoyz
Copy link
Member

hsluoyz commented Dec 10, 2021

@sallycaoyu will be busy and cannot perform this task these days.

@Abingcbc can you take this issue as one of next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants