Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate package release #90

Closed
GopherJ opened this issue Apr 6, 2020 · 12 comments
Closed

automate package release #90

GopherJ opened this issue Apr 6, 2020 · 12 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@GopherJ
Copy link
Member

GopherJ commented Apr 6, 2020

See: https://github.com/semantic-rs/semantic-rs

@GopherJ GopherJ changed the title automate release automate package release Apr 6, 2020
@PsiACE
Copy link
Contributor

PsiACE commented Apr 8, 2020

Do you mean we need to migrate the existing auto release to semantic release?

@GopherJ
Copy link
Member Author

GopherJ commented Apr 8, 2020

I mean when we accept a PR, I would like to use sematic-rs for getting the new version and then after accepting the new PR.

It should be able to create a new git tag then let github actions release the new package (Thanks for what you have done).

Now we need to create a tag manually which can be improved

@GopherJ
Copy link
Member Author

GopherJ commented Apr 8, 2020

Maybe we don't need to migrate but just adding semantic-rs for version discoversing and changelog generation.

The package release is good enough

@PsiACE
Copy link
Contributor

PsiACE commented Apr 9, 2020

I will try it. Actually, I've written it, but I haven't tested it

@PsiACE
Copy link
Contributor

PsiACE commented Apr 9, 2020

See #100 . My personal recommendation is to run semantic-rs only locally, rather than using CI

@hsluoyz
Copy link
Member

hsluoyz commented May 4, 2020

@GopherJ is this already done?

@hsluoyz hsluoyz added the enhancement New feature or request label May 4, 2020
@hackerchai
Copy link
Member

@GopherJ is this already done?

This is still remaining to be done. I am working on this.

@PsiACE
Copy link
Contributor

PsiACE commented May 4, 2020

There are two points to note:

@hsluoyz @hackerchai

@hackerchai
Copy link
Member

There are two points to note:

@hsluoyz @hackerchai

I have communicated with @GopherJ , we agree to use https://github.com/github/semantic to do this job.

@PsiACE
Copy link
Contributor

PsiACE commented May 4, 2020

There are two points to note:

@hsluoyz @hackerchai

I have communicated with @GopherJ , we agree to use https://github.com/github/semantic to do this job.

Sounds good, do it.

@GopherJ
Copy link
Member Author

GopherJ commented May 4, 2020

@PsiACE @hackerchai just to correct, it's: https://github.com/semantic-release/semantic-release which should be fine

@GopherJ GopherJ added this to the v1.0.0 milestone May 9, 2020
@GopherJ GopherJ closed this as completed May 13, 2020
@GopherJ
Copy link
Member Author

GopherJ commented May 13, 2020

Finally I made it works using something like this:

https://github.com/casbin/casbin-rs/blob/master/.github/workflows/release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants