Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the package name #30

Closed
xcaptain opened this issue Dec 23, 2019 · 4 comments
Closed

Rename the package name #30

xcaptain opened this issue Dec 23, 2019 · 4 comments
Assignees
@xcaptain
Labels
enhancement New feature or request

Comments

@xcaptain
Copy link
Contributor

xcaptain commented Dec 23, 2019 •
edited
Loading

Currently, we use casbin-rs as the package name in Cargo.toml, would be better to use casbin directly. Also the name casbin is available, see: https://crates.io/search?q=casbin
@xcaptain xcaptain mentioned this issue Dec 23, 2019
Closed
24 tasks
@hsluoyz
Copy link
Member

hsluoyz commented Dec 23, 2019

@xcaptain of course we should use casbin directly. For each language's package manager, we usually use casbin name, like npmjs, etc. The differentiation like node-casbin, casbin-rs is mainly for GitHub repo names.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 24, 2019

Can we release it?

@xcaptain
Copy link
Contributor Author

I will release as soon as possible. please take a look at #28

@xcaptain
Copy link
Contributor Author

Changed at #28 and the 0.1.0 version just published https://crates.io/crates/casbin

@hsluoyz hsluoyz added the enhancement New feature or request label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcaptain xcaptain

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsluoyz @xcaptain