Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we stick with rust clippy #15

Closed
xcaptain opened this issue Aug 19, 2019 · 2 comments
Closed

Should we stick with rust clippy #15

xcaptain opened this issue Aug 19, 2019 · 2 comments

Comments

@xcaptain
Copy link
Contributor

xcaptain commented Aug 19, 2019 •
edited
Loading

Clippy is a static analysis tool, Recently I tested this project using cargo clippy and found a lot of errors and warnings.

图片

We have already setup cargo fmt in travis-ci, should we fix cargo clippy errors before committing?

Setup clippy with travis-ci is easy, https://github.com/rust-lang/rust-clippy
@xcaptain
Copy link
Contributor Author

@GopherJ Do you think we should stick with clippy or do you have interest to do this task?

@xcaptain xcaptain mentioned this issue Aug 19, 2019
Closed
24 tasks
@GopherJ
Copy link
Member

GopherJ commented Aug 19, 2019

@xcaptain we should stick and I'll handle it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xcaptain @GopherJ