Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up interpolation of time dimensions in various sub-xdss #307

Closed
2 tasks done
FedeMPouzols opened this issue Nov 20, 2024 · 0 comments · Fixed by #309
Closed
2 tasks done

Clean up interpolation of time dimensions in various sub-xdss #307

FedeMPouzols opened this issue Nov 20, 2024 · 0 comments · Fixed by #309
Assignees
Labels
clean up Issue related to code cleanup

Comments

@FedeMPouzols
Copy link
Collaborator

FedeMPouzols commented Nov 20, 2024

We have very similar code doing the same thing to interpolate and rename time_pointing, time_ephemeris, time_syscal, time_phase_cal to the main_xds time, after last few rounds of updates to the schema.

  • Clean this up and unify into single function(s).
  • While looking into this I also realized that when not interpolating pointing, its time dimension was not named correctly. Fix that.
@FedeMPouzols FedeMPouzols self-assigned this Nov 20, 2024
@FedeMPouzols FedeMPouzols added the clean up Issue related to code cleanup label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Issue related to code cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant