Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add Test Coverage #97

Closed
busypeoples opened this issue May 21, 2016 · 4 comments
Closed

Add Test Coverage #97

busypeoples opened this issue May 21, 2016 · 4 comments

Comments

@busypeoples
Copy link
Contributor

No description provided.

@busypeoples
Copy link
Contributor Author

busypeoples commented May 22, 2016

We will need a strategy here. function.toString() seems to cause troubles in an instanbul context. This will break the propsToVariation function tests.

gotwarlost/istanbul#310

// istanbul context
"onClick": function onClick(){__cov_YrynSvfAB9MZhTh3r7xFHA.f['16']++;__cov_YrynSvfAB9MZhTh3r7xFHA.s['55']++;return undefined;}

// normal context
"onClick": function onClick() {
    return undefined;
}

@nikgraf
Copy link
Member

nikgraf commented May 23, 2016

@busypeoples
@neuling had the idea to potential call these function with an apply. This would fix the test and potential avoid context issues on the front-end?!?

@busypeoples
Copy link
Contributor Author

Sounds good. Let's give it try. Avoiding function.toString(), will definitely fix this specific issue. All other tests work out of the box with istanbul.

@busypeoples
Copy link
Contributor Author

I think we can close this issue. All tests run through. @nikgraf

@nikgraf nikgraf closed this as completed May 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants