Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_link_table: include parent nodes #126

Open
zkamvar opened this issue May 10, 2023 · 0 comments
Open

make_link_table: include parent nodes #126

zkamvar opened this issue May 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@zkamvar
Copy link
Contributor

zkamvar commented May 10, 2023

I've been bashing my head against this wall for the last half hour and finally figured out what's going on.

In the lesson transition, I use the $node column of the table to fix any broken links without having to re-read the document. This works for markdown images, but for HTML images, this does not work even though they are present in the table because they are parsed from the text and only exist as ephemeral nodes that the original document does not know about. This leads to patterns where I attempt to fix these in-place, but eventually fail and have to fix them manually.

Having the parent node will allow me to detect the underlying HTML node and fix the images that way.

@zkamvar zkamvar added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant