Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions when trainee submits "Get involved" #2472

Closed
maneesha opened this issue Jul 14, 2023 · 3 comments · Fixed by #2492
Closed

Actions when trainee submits "Get involved" #2472

maneesha opened this issue Jul 14, 2023 · 3 comments · Fixed by #2492

Comments

@maneesha
Copy link
Contributor

After a trainee successfully submits a "Get involved" step, the trainee can not currently view, edit, or delete their submission, and the trainee is able to create another submission.

The trainee should see the following:

  • The trainee should see a summary of their submission with a message that says "Thank you. Your submission will be reviewed in 7-10 days."
  • The trainee should be able to edit or delete their submission.
  • The trainee should not be able to submit another entry.
@elichad
Copy link
Contributor

elichad commented Jul 20, 2023

To allow trainees to update/delete their submission, the easiest (and probably most robust) way is to split the form on to a separate page. I think this might work better for the original submission too, especially in the case where they have been asked to repeat the step, as that can end up with quite a lot of text. Here are some screenshots of what that looks like. @karenword @klbarnes20 what are your thoughts on this?

Note I'm aware of some display improvements that could be made (e.g. contrast of the yellow text and visual distinction of the submission details vs info text), I'm asking just about the workflow here.

Before making a submission:
Get Involved not submitted yet. Button "Submit a Get Involved activity"
Alternatively, when asked to repeat:
Get Involved asked to repeat as of 20 July 2023. Administrator comments: URL does not go to a workshop website. Details of your submission are below. (Submission details omitted.) Button "Submit another Get Involved activity"
Clicking the button above takes you to the create submission page (edit page is much the same with title "Update your Get Involved submission"):
New page titled "Submit your Get Involved activity" with the Get Involved form, which has not been otherwise changed
After submitting:
Get Involved not evaluated yet as of 20 July 2023. Your submission will be evaluated within 7-10 days. You may update or delete your submission before it is evaluated. If you delete it, you will be allowed to create a new submission afterward. (Submission details omitted.) Buttons "Edit" and "Delete"

@karenword
Copy link

LGTM! Thanks @elichad !

@klbarnes20
Copy link
Contributor

I really like this @elichad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants