Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping up with Snakemake changes #47

Open
tbooth opened this issue Sep 21, 2023 · 2 comments
Open

Keeping up with Snakemake changes #47

tbooth opened this issue Sep 21, 2023 · 2 comments
Labels
reviewer Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17

Comments

@tbooth
Copy link
Collaborator

tbooth commented Sep 21, 2023

From @jdblischak

Snakemake 7.8 introduced a few big changes. Your tutorial is based on version 5.32.2. You have a box in the episode "How Snakemake plans what jobs to run" that notes these changes in behavior. However, given that Snakemake 7.8 was released in May 2022, at some point it will make more sense for the episode to describe the 7.8+ behavior, and then only mention the <7.8 behavior in a box.

Another cool Snakemake feature that I really like is the ability to freeze the conda environments used in each rule. This would be worth mentioning in the lesson on conda integration

@tbooth tbooth added the reviewer Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17 label Sep 21, 2023
@tbooth
Copy link
Collaborator Author

tbooth commented Sep 26, 2023

Agreed, but as noted elsewhere the (#36) the 7.8 behaviour has some issues and may change again.

I'm hoping I can get the lesson approved for inclusion in the Lab in the current format before chasing the newest Snakemake, as the upgrade will entail re-testing everything and updating a lot of sample outputs where errors and wording have changed.

@tbooth
Copy link
Collaborator Author

tbooth commented Mar 19, 2024

The current version of the lesson now uses Snakemake 8.5.3. This is a major update to Snakemake itself, refactoring a bunch of features into optional modules. Hopefully it represents the Snakemake core, which is what this material mostly covers, becoming more stable over time. This will reduce the burden of maintenance to "chase" new Snakemake features in this material.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewer Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17
Projects
None yet
Development

No branches or pull requests

1 participant