New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Create a function" exercise in 04-code-readability uses an old version of read_json_to_dataframe #87

Closed

kkh451 opened this issue Jun 28, 2024 · 1 comment

Assignees

Labels

bug

Contributor

kkh451 commented Jun 28, 2024

The "Create a function" exercise in 04-code-readability uses an old version of read_json_to_dataframe from https://github.com/carpentries-incubator/astronout-data-analysis-fair/

Solutions

Revert the definition of read_json_to_dataframe if it fits with the testing episode OR
Update the exercise to match the updated function

kkh451 added the bug label

kkh451 mentioned this issue

Review of episodes 3 - 4: Version Control and Code Readability #91

Merged

anenadic assigned colinsauze

Collaborator

anenadic commented Oct 24, 2024

Think this is no longer relevant since #134.

anenadic closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment