URLBase() supports calls to url() for generic responses #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
caronc
force-pushed
the
default-apprise-url-gen
branch
from
94f71ab
to
3924407
Compare
caronc
force-pushed
the
default-apprise-url-gen
branch
from
3924407
to
21866b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): apprise-api/101
In preparation for webhook support with the Apprise API, it only makes sense to re-leverage all of the URL parsing and handling done in the Apprise base library (instead of writing it all again).
This merge request will make it easy to Parse a defined webhook URL a lot like an Apprise based one (grabbing options, user/pass combos, timeouts, and everything else) when defined.
Checklist
flake8)Testing
No functional testing required as it is covered in the added unit tests which test what is expected.