Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases to verify +/plus is supported in to emails #779

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 9, 2022

Description:

Related issue (if applicable): #488

To address comment added to issue above about the non-support for the '+' symbol in emails. Added test cases which appear to prove the functionality is working as proposed unless i'm overlooking something. The syntax would be any of the following:

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@488-support-plus-char-in-to-email

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "mailto://user:pass@domain/[email protected]"

@caronc caronc force-pushed the 488-support-plus-char-in-to-email branch from bb486a1 to dc11100 Compare December 10, 2022 17:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5f0e9e4) compared to base (5f0e9e4).
Patch has no changes to coverable lines.

❗ Current head 5f0e9e4 differs from pull request most recent head dc11100. Consider uploading reports for the commit dc11100 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #779   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          116       116           
  Lines        14945     14945           
  Branches      3052      3052           
=========================================
  Hits         14945     14945           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caronc caronc merged commit 647962b into master Dec 10, 2022
@caronc caronc deleted the 488-support-plus-char-in-to-email branch December 10, 2022 20:17
YoRyan pushed a commit to YoRyan/apprise that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants