Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Could not send messages to groups ending in "=" #670

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Bugfix: Could not send messages to groups ending in "=" #670

merged 1 commit into from
Sep 21, 2022

Conversation

oddlama
Copy link
Contributor

@oddlama oddlama commented Sep 21, 2022

Description:

A lot of signal groups end in "=" as they are base64 encoded. The = isn't matched and therefore stripped before passing it to the api, resulting in the group not being recognized. The fix is extremely simple.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3d1e506) compared to base (2d33935).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines        14684     14684           
  Branches      2783      2783           
=========================================
  Hits         14684     14684           
Impacted Files Coverage Δ
apprise/plugins/NotifySignalAPI.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caronc
Copy link
Owner

caronc commented Sep 21, 2022

Thank you for the PR. It looks good 🚀

@caronc caronc merged commit 4b4e4ff into caronc:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants