Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgram:// supports chat_id:topic arguments #1028

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 28, 2023

Description:

Related issue (if applicable): #1021

Telegram plugin supports: tgram://{chat_id}:{topic} now (using a colon (:) as a delimiter. Hence the following is valid too: tgram://{chat_id}:{topic}/{chat_id2}:{topic2}/...

Topics are purely optional

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1021-telegram-chatid-to-topics

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
     "tgram://credentials/chat_id:topic"

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dcf769) 99.27% compared to head (ac4c94a) 99.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         136      136           
  Lines       17657    17669   +12     
  Branches     3603     3603           
=======================================
+ Hits        17529    17541   +12     
  Misses        119      119           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit d6e0d2e into master Dec 28, 2023
12 checks passed
@caronc caronc deleted the 1021-telegram-chatid-to-topics branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants