-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Notifications and Emoji Engine on Demand #1020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
- Coverage 99.55% 99.27% -0.28%
==========================================
Files 130 136 +6
Lines 17281 17657 +376
Branches 3523 3603 +80
==========================================
+ Hits 17204 17529 +325
- Misses 68 119 +51
Partials 9 9 ☔ View full report in Codecov by Sentry. |
caronc
force-pushed
the
load-on-demand-refactor
branch
from
December 22, 2023 22:39
5c9eb9e
to
f5bb97f
Compare
caronc
force-pushed
the
load-on-demand-refactor
branch
from
December 27, 2023 18:52
31e8686
to
b421dfd
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): n/a
This is a massive re-factor of how notifications are loaded into memory. It also refactors the way the Emoji engine is loaded (saving on memory when it's not needed).
After this PR, notifications are no longer loaded on the
import apprise
command. Instead leveraging a new library, they are only imported on demand.Breaking Changes
Those using the library as it was intended will not see any breakage at all.
Checklist
flake8
)