BaseCSVField doesn't raise "required" error

[neostimul]

I create the filter with required DateField.

class SomeFilter(filters.FilterSet):
    class Meta:
        model = Data
        fields = {
            'date': ('range', ),
        }
        filter_overrides = {
             models.DateField: {
                 'filter_class': filters.DateFilter,
                 'extra': lambda f: {
                     'required': True,
                 },
             },
         }

But on validation stage BaseCSVField doesn't raise the required error, cause value is None and it just returns None, without cleaning the base class

class BaseCSVField(forms.Field):
    ....

    def clean(self, value):
        if value is None:
--->        return None
        return [super(BaseCSVField, self).clean(v) for v in value]

[carltongibson]

Should be fixed by #854

[neostimul]

Yes, it fixed. Thank you

[neostimul]

No, i was wrong. BaseCSVField still does not raise required exception when date is not specified

when value is None (can be specified as None or not specified) must call clean value of Base class

    def clean(self, value):
        if value is None:
            value = super(BaseCSVField, self).clean(value)
            # or raise ValidationError(self.error_messages['required'], code='required')
        return [super(BaseCSVField, self).clean(v) for v in value]

or we have not required error

I mean work with this PR https://github.com/carltongibson/django-filter/pull/854/files
must be when required is True

with self.assertRaises(forms.ValidationError):
    self.field.clean(None)

I want to create a DateRangeFilter for random dates (example: /?date__range=[2018-01-01, 2018-02-02] )

I do

class DateRangeFilter(filters.BaseRangeFilter, filters.DateFilter):
    base_field_class = BaseRangeField

And have no raise reuired exception when /?date__range= or nothing params at all

May be i do something wrong.