From 258735d890b78e6ac76d0dc3c38d974b31038a6f Mon Sep 17 00:00:00 2001 From: alrex Date: Fri, 25 Jun 2021 07:11:33 -0700 Subject: [PATCH] Adding environment variables for event and link attribute limits (#1751) --- CHANGELOG.md | 2 ++ spec-compliance-matrix.md | 2 ++ specification/sdk-environment-variables.md | 12 +++++++----- specification/trace/sdk.md | 4 ++++ 4 files changed, 15 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2abae4dca60..2b40bd7bbd3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ release. ### Traces +- Adding environment variables for event and link attribute limits. ([#1751](https://github.com/open-telemetry/opentelemetry-specification/pull/1751)) + ### Metrics - Clarify the limit on the instrument unit. diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 56b7acad94f..878dc5e6393 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -143,6 +143,8 @@ Note: Support for environment variables is optional. |OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | - | + | | + | + | - | | + | - | | | |OTEL_SPAN_EVENT_COUNT_LIMIT | - | + | | + | + | - | | + | - | | | |OTEL_SPAN_LINK_COUNT_LIMIT | - | + | | + | + | - | | + | - | | | +|OTEL_EVENT_ATTRIBUTE_COUNT_LIMIT | | | | | | | | | | | | +|OTEL_LINK_ATTRIBUTE_COUNT_LIMIT | | | | | | | | | | | | |OTEL_TRACES_SAMPLER | - | + | | + | + | + | | - | - | | | |OTEL_TRACES_SAMPLER_ARG | - | + | | + | + | + | | - | - | | | diff --git a/specification/sdk-environment-variables.md b/specification/sdk-environment-variables.md index 7bd6f866192..38792b6a207 100644 --- a/specification/sdk-environment-variables.md +++ b/specification/sdk-environment-variables.md @@ -78,11 +78,13 @@ Depending on the value of `OTEL_TRACES_SAMPLER`, `OTEL_TRACES_SAMPLER_ARG` may b See the SDK [Span Limits](trace/sdk.md#span-limits) section for the definition of the limits. -| Name | Description | Default | Notes | -| ------------------------------- | ------------------------------------ | ------- | ----- | -| OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | Maximum allowed span attribute count | 128 | | -| OTEL_SPAN_EVENT_COUNT_LIMIT | Maximum allowed span event count | 128 | | -| OTEL_SPAN_LINK_COUNT_LIMIT | Maximum allowed span link count | 128 | | +| Name | Description | Default | Notes | +| -------------------------------- | ---------------------------------------------- | ------- | ----- | +| OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | Maximum allowed span attribute count | 128 | | +| OTEL_SPAN_EVENT_COUNT_LIMIT | Maximum allowed span event count | 128 | | +| OTEL_SPAN_LINK_COUNT_LIMIT | Maximum allowed span link count | 128 | | +| OTEL_EVENT_ATTRIBUTE_COUNT_LIMIT | Maximum allowed attribute per span event count | 128 | | +| OTEL_LINK_ATTRIBUTE_COUNT_LIMIT | Maximum allowed attribute per span link count | 128 | | ## OTLP Exporter diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 9e198aadf4f..980eb2d8cc0 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -342,6 +342,10 @@ public final class SpanLimits { public int getAttributeCountLimit(); + public int getAttributeCountPerEventLimit(); + + public int getAttributeCountPerLinkLimit(); + public int getEventCountLimit(); public int getLinkCountLimit();