Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with kubernetes 1.25 #133

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

duanhongyi
Copy link
Contributor

Carina v0.11.0 is not compatible with the latest kubernetes 1.25. I upgraded the dependent project and it is running well in my kubernetes 1.25 cluster.

@zhangkai8048
Copy link
Contributor

/lgtm

@antmoveh
Copy link
Contributor

antmoveh commented Sep 5, 2022

Carina bot is dead. Wait for him to start

@antmoveh
Copy link
Contributor

antmoveh commented Sep 5, 2022

@duanhongyi

  1. 这个golang版本为何要升级到1.19?在1.17.5不可以吗?
  2. 1.25废弃了psp, 这样升级完还是无法部署的吧,在部署yaml中我们使用了psp https://github.com/carina-io/carina/blob/main/deploy/kubernetes/csi-controller-psp.yaml

@fanhaouu
Copy link
Member

fanhaouu commented Sep 5, 2022

@duanhongyi Does it work in k8s 1.18~1.24, if you upgraded the dependent project

@duanhongyi
Copy link
Contributor Author

duanhongyi commented Sep 5, 2022

@duanhongyi

  1. 这个golang版本为何要升级到1.19?在1.17.5不可以吗?
  2. 1.25废弃了psp, 这样升级完还是无法部署的吧,在部署yaml中我们使用了psp https://github.com/carina-io/carina/blob/main/deploy/kubernetes/csi-controller-psp.yaml

1、kubernetes 1.25的go.mod声明使用的是1.19,我当时在1.17.5下编译报错,或许最终能解决但是感觉费时费力。
2、这个在我的k3s 1.25集群中没有影响,至于正常的kube我这边没有这个环境,无法测试。

@duanhongyi
Copy link
Contributor Author

@duanhongyi Does it work in k8s 1.18~1.24, if you upgraded the dependent project

1.24我已经测试过了,我稍后会在1.18上做一下测试。

@duanhongyi
Copy link
Contributor Author

image

@antmoveh
Copy link
Contributor

antmoveh commented Sep 5, 2022

image

你是用Helm部署的 还是使用那个部署脚本部署的。
目前helm里没有psp的内容。

@antmoveh
Copy link
Contributor

antmoveh commented Sep 5, 2022

Helm chart没有部署psp,也是能正常使用
@fanhaouu 我们是不是可以考虑去掉psp的yaml呢

@fanhaouu
Copy link
Member

fanhaouu commented Sep 5, 2022

Helm chart没有部署psp,也是能正常使用 @fanhaouu 我们是不是可以考虑去掉psp的yaml呢
1.25+记得有内置的准入控制策略;其次,低版本的k8s没有psp是不是没法正常运行

@duanhongyi
Copy link
Contributor Author

@antmoveh 是helm

@antmoveh
Copy link
Contributor

antmoveh commented Sep 6, 2022

@duanhongyi @fanhaouu

① 这个为经过测试在 <k8s 1.18版本中,由于csidriver驱动版本原因无法部署成功,也就是k8s>=1.18将会定义为他支持的版本范围并加入到readme.md中
② 在k8s1.18版本中不创建psp将导致carina无法创建存储卷.

  Warning  ProvisioningFailed    4s (x5 over 19s)   carina.storage.io_csi-carina-controller-69f6fc6ddb-2spdn_5f7c9421-0e5d-462c-a2ff-3adaa1bab4f8  failed to provision volume with StorageClass "csi-carina-lvm": rpc error: code = Internal desc = an empty namespace may not be set when a resource name is provided

③ helm中需要将psp 内容添加, @zhangkai8048
④ 我们将制作一个表格,来表示k8s版本和支持他的carina版本
⑤ 该pr暂时挂这,例会讨论一下关于如何支持k8s>=1.25的问题,可能需要划分不同的分支

@antmoveh
Copy link
Contributor

antmoveh commented Sep 6, 2022

/do-not-merge hold

@antmoveh antmoveh added enhancement New feature or request do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 6, 2022
@duanhongyi
Copy link
Contributor Author

收到 @antmoveh

@antmoveh
Copy link
Contributor

antmoveh commented Sep 8, 2022

@duanhongyi
main分支支持范围为v1.18-1.24 这是一个主流版本范围长期支持

对于kubernetes >1.25版本 将会专门为他建立一个分支,来合并这块代码。 可以稍后将PR提到release-k8s-1.25
关于release-k8s-1.25处于实验状态,新的版本功能更新会落后于main分支

@duanhongyi
Copy link
Contributor Author

@duanhongyi @fanhaouu

① 这个为经过测试在 <k8s 1.18版本中,由于csidriver驱动版本原因无法部署成功,也就是k8s>=1.18将会定义为他支持的版本范围并加入到readme.md中 ② 在k8s1.18版本中不创建psp将导致carina无法创建存储卷.

  Warning  ProvisioningFailed    4s (x5 over 19s)   carina.storage.io_csi-carina-controller-69f6fc6ddb-2spdn_5f7c9421-0e5d-462c-a2ff-3adaa1bab4f8  failed to provision volume with StorageClass "csi-carina-lvm": rpc error: code = Internal desc = an empty namespace may not be set when a resource name is provided

③ helm中需要将psp 内容添加, @zhangkai8048 ④ 我们将制作一个表格,来表示k8s版本和支持他的carina版本 ⑤ 该pr暂时挂这,例会讨论一下关于如何支持k8s>=1.25的问题,可能需要划分不同的分支

你这个错误是哪个组件的错误,我测试1.18.0没有问题?

@duanhongyi
Copy link
Contributor Author

image

@duanhongyi
Copy link
Contributor Author

#141

@antmoveh
Copy link
Contributor

k8s > 1.25的支持 现在应该需要了。

@redref
Copy link
Contributor

redref commented May 2, 2023

Any update on 1.25 compatibility timeline ?

Used quite the same PR our side, would be nice to have it upstream.

@antmoveh
Copy link
Contributor

antmoveh commented May 4, 2023

要支持k8s > 1.25, 该分支即将合并进main分支

@antmoveh
Copy link
Contributor

antmoveh commented May 5, 2023

/lgtm
/approve

@antmoveh antmoveh added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 5, 2023
@carina-ci-bot carina-ci-bot merged commit 9872cf6 into carina-io:main May 5, 2023
@carina-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antmoveh, duanhongyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@carina-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antmoveh, duanhongyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redref
Copy link
Contributor

redref commented May 9, 2023

Unless mistaken, this change is not included in 0.12.0. Would it be possible to do a new release for this ?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. enhancement New feature or request kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants