Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing libs and includes? #353

Open
NobodyXu opened this issue Sep 7, 2022 · 4 comments
Open

Support installing libs and includes? #353

NobodyXu opened this issue Sep 7, 2022 · 4 comments

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Sep 7, 2022

wasmerio/wasmer#3106

wasmer pre-built tarballs include not only bins, but also libs and includes necessary for wasmer create-exe.
Perhaps we can add new manifest configurations libs = true and includes = true which will install them to .cargo if present?

@passcod
Copy link
Member

passcod commented Sep 7, 2022

That feels very much like building an entire feature just for a single package, and is strongly departing from the .cargo usage. Additionally, on Windows, it's my understanding that DLLs placed next to a binary will get loaded by that binary (it's how a lot of game piracy works), so we can't just dump them in a folder or something.

@NobodyXu
Copy link
Member Author

NobodyXu commented Sep 7, 2022

That feels very much like building an entire feature just for a single package, and is strongly departing from the .cargo usage.

Well, that feature is indeed only used by wasmer currently, but perhaps it might also be used by other softwares?

Additionally, on Windows, it's my understanding that DLLs placed next to a binary will get loaded by that binary (it's how a lot of game piracy works), so we can't just dump them in a folder or something.

Ahhh, sounds like a lot complex than I think.

I'm not sure whether my proposed solution is the right one to do, but I'd like @passcod your advice.
Alternatives would be wasmer downloading the includes/ and libs/ themselves.

@passcod
Copy link
Member

passcod commented Sep 7, 2022

I think let's park this for now until we have some other project that wants it, and that could help inform the approach to take, or we're ready to really progress on WASI.

It's the more boring path, but I think the priority is getting to 1.0, getting to a stable, secure place that can then serve as the launchpad for all this more ambitious stuff.

@NobodyXu
Copy link
Member Author

NobodyXu commented Sep 7, 2022

@passcod Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants