Simplify ostream.h SFINAE using a helper syntax #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please comment or remove the |
github-actions
bot
added
the
inactive
jonmeow
approved these changes
Mar 11, 2022
|
(looking at the age of this PR, maybe I just lost track of it? Sorry.) |
github-actions
bot
removed
the
inactive
Co-authored-by: Jon Meow <[email protected]>
pk19604014
added a commit
that referenced
this pull request
Mar 22, 2022
…like invalid syntax (#1120) * Replaced std::exit() with return llvm::Expected/llvm::Error<T> for expected errors like invalid syntax. * Use llvm::formatv() for formatting lexer error messages. x * Addresed merge errors. * Fixed impl scope. * Made ErrorBuilder::operator<< nodiscard, to catch code forgetting 'return' in 'return FATAL_COMPILATION_ERROR()'. * FatalComplationError() -> ParseAndLexContext::RecordLexerError(). Other usages of ERROR_TOKEN in lexer.lpp were actually supposed to be END_OF_FILE. * Update executable_semantics/syntax/parse_and_lex_context.h Co-authored-by: Jon Meow <[email protected]> * Code review fixes. * Update executable_semantics/syntax/parser.ypp Co-authored-by: Jon Meow <[email protected]> * More code review fixes. * Update executable_semantics/interpreter/type_checker.h Co-authored-by: Jon Meow <[email protected]> * Yet more code review fixes... * Update executable_semantics/syntax/lexer.lpp Co-authored-by: Jon Meow <[email protected]> * code review comments * Update executable_semantics/interpreter/interpreter.cpp Co-authored-by: Geoff Romer <[email protected]> * Apply suggestions from code review Co-authored-by: Jon Meow <[email protected]> * Update executable_semantics/syntax/lexer.lpp Co-authored-by: Jon Meow <[email protected]> * code review * code review * Apply suggestions from code review Co-authored-by: Jon Meow <[email protected]> * formatted code * review comments * Switched to the new ErrorOr<V> error implementation * code review comments * fixed comment * restored ostream.h as #976 makes the change unnecesary * review comments Co-authored-by: Jon Meow <[email protected]> Co-authored-by: Geoff Romer <[email protected]>
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
Co-authored-by: Jon Meow <[email protected]>
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
…like invalid syntax (#1120) * Replaced std::exit() with return llvm::Expected/llvm::Error<T> for expected errors like invalid syntax. * Use llvm::formatv() for formatting lexer error messages. x * Addresed merge errors. * Fixed impl scope. * Made ErrorBuilder::operator<< nodiscard, to catch code forgetting 'return' in 'return FATAL_COMPILATION_ERROR()'. * FatalComplationError() -> ParseAndLexContext::RecordLexerError(). Other usages of ERROR_TOKEN in lexer.lpp were actually supposed to be END_OF_FILE. * Update executable_semantics/syntax/parse_and_lex_context.h Co-authored-by: Jon Meow <[email protected]> * Code review fixes. * Update executable_semantics/syntax/parser.ypp Co-authored-by: Jon Meow <[email protected]> * More code review fixes. * Update executable_semantics/interpreter/type_checker.h Co-authored-by: Jon Meow <[email protected]> * Yet more code review fixes... * Update executable_semantics/syntax/lexer.lpp Co-authored-by: Jon Meow <[email protected]> * code review comments * Update executable_semantics/interpreter/interpreter.cpp Co-authored-by: Geoff Romer <[email protected]> * Apply suggestions from code review Co-authored-by: Jon Meow <[email protected]> * Update executable_semantics/syntax/lexer.lpp Co-authored-by: Jon Meow <[email protected]> * code review * code review * Apply suggestions from code review Co-authored-by: Jon Meow <[email protected]> * formatted code * review comments * Switched to the new ErrorOr<V> error implementation * code review comments * fixed comment * restored ostream.h as #976 makes the change unnecesary * review comments Co-authored-by: Jon Meow <[email protected]> Co-authored-by: Geoff Romer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.