Sort diagnostic output from the driver by default #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Mar 17, 2022
| return lhs.location.column_number < rhs.location.column_number; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
return std::tie(lhs.location.line_number, lhs.location.column_number) < std::tie(rhs.location.line_number, rhs.location.column_number);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to keep streamed behavior.
Note the flag is kludged in... I would use llvm::cl flag support by default, but the subcommand logic is already avoiding LLVM's subcommand support -- I'm trying to figure out if that's deliberate and we'll build our own, or if it's incidental in which case I'd probably refactor the driver code for llvm::cl use separately.