test(InterstitialScreen): increase code coverage #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamikaanu96
requested review from
matthewgallo and
devadula-nandan
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anamikaanu96
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6316 +/- ##
==========================================
+ Coverage 78.68% 79.06% +0.38%
==========================================
Files 395 395
Lines 12880 12880
Branches 4256 4256
==========================================
+ Hits 10134 10183 +49
+ Misses 2746 2697 -49
|
matthewgallo
approved these changes
Oct 30, 2024
| }); | ||
| const closeBtn = screen.getByLabelText('Close'); | ||
| await act(() => userEvent.click(closeBtn)); | ||
| expect(onClose).toBeCalled(); |
There was a problem hiding this comment.
Just a note, you could use .toHaveBeenCalledTimes(1) here to make sure it's called the number of times expected.
davidmenendez
approved these changes
Oct 30, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 30, 2024
bc3fa66
32 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6264
Increased code coverage
What did you change?
packages/ibm-products/src/components/InterstitialScreen/InterstitialScreen.test.js
packages/ibm-products/src/components/InterstitialScreen/InterstitialScreen.tsx
How did you test and verify your work? yarn test coverage:report