Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotificationsPanel: remove any dynamic values from storybook implementation #6808

Closed
matthewgallo opened this issue Jan 29, 2025 · 5 comments · Fixed by #6828
Closed

NotificationsPanel: remove any dynamic values from storybook implementation #6808

matthewgallo opened this issue Jan 29, 2025 · 5 comments · Fixed by #6828
Assignees
@AlexanderMelox
Labels
component: NotificationsPanel component: PageHeader Debt Experience dropped or altered for implementation release and deferred until later priority: medium Pick up in the next two quarters role: dev

Comments

@matthewgallo
Copy link
Member

Percy continues to flag NotificationsPanel as having visual changes, but this is only because the story implementations contains dynamic values for the timestamps. In order to stop the percy failures we need to just refactor the story to remove dynamic values.
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jan 29, 2025
@elycheea
Copy link
Contributor

One of the PageHeader stories also uses a dynamic value for the current/previous month so think if we’re trying to nip these excess Percy failures, we should include that as well.

@elycheea elycheea moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Jan 29, 2025
@elycheea elycheea added component: PageHeader Debt Experience dropped or altered for implementation release and deferred until later role: dev priority: medium Pick up in the next two quarters labels Jan 29, 2025
@AlexanderMelox AlexanderMelox self-assigned this Jan 30, 2025
@AlexanderMelox AlexanderMelox moved this from Needs refinement 🤓 to In progress in Carbon for IBM Products Jan 30, 2025
@AlexanderMelox
Copy link
Contributor

Already fixed the notifications, @elycheea which part of the page header uses dynamic values?

@elycheea
Copy link
Contributor

This story, but it only changes monthly so ... we’ll probably see all the Percy failures for it in two days when it switches to January 2025. 😅

@AlexanderMelox
Copy link
Contributor

Image Wait i still don't see what part changes?

@matthewgallo
Copy link
Member Author

It's hard to catch, it's in the breadcrumbs 😄

@AlexanderMelox AlexanderMelox mentioned this issue Jan 31, 2025
Merged
@AlexanderMelox AlexanderMelox moved this from In progress to In review 👀 in Carbon for IBM Products Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🚀 in Carbon for IBM Products Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderMelox AlexanderMelox

Labels
component: NotificationsPanel component: PageHeader Debt Experience dropped or altered for implementation release and deferred until later priority: medium Pick up in the next two quarters role: dev
Projects
Carbon for IBM Products
Status: Done 🚀
Milestone
No milestone
3 participants
@elycheea @matthewgallo @AlexanderMelox