Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component : Icon button bar #4240

Closed
2 tasks
Tracked by #4611
elycheea opened this issue Feb 7, 2024 · 0 comments
Closed
2 tasks
Tracked by #4611

New Component : Icon button bar #4240

elycheea opened this issue Feb 7, 2024 · 0 comments
Assignees
Labels
area: migration ➡️ Migration of Security package to IBM Products

Comments

@elycheea
Copy link
Contributor

elycheea commented Feb 7, 2024

Icon button bar

Please refer to #4052 for more details about migrating legacy Security components to Products v2.

Brief description

This component is to be migrated from the @carbon/ibm-security package (found in main_v1 packages/patterns) to our main branch and is part of the initiative documented in #4052 and #4036.

Migrate IconButtonBar from Products v1 / Security / IconButtonBar to Products v2.

References: GitHub, Storybook.

Details

Link to Security version

Notes on this migration
For this initial release, we will follow these two principles to keep working moving forward and to unblock teams reliant on the older package —

  1. Zero design changes from Security to Products. This make it easier to compare old component to new component. Any design updates can as followup.
  2. New components must meet Products’ code specs. Rather than copy and paste old code from Security to Products, we will refactor it to ensure they’re up to date.

Summary from @paul-balchin-ibm’s initial review —

IconButtonBar

GitHub, Storybook

TLDR

  • Follows Carbon for IBM Products component architecture.

PROBLEMATIC IMPORTS

import { OverflowMenu, OverflowMenuItem } from '../..';
import IconButton from '../IconButton';

Links to other materials

e.g. sketch files, icons, images, prototypes

Design contact(s)

Tasks

Before starting work on this epic, please review and complete the following.

Working in Carbon for IBM Products package

Acceptance criteria

Preview Give feedback
@elycheea elycheea added the area: migration ➡️ Migration of Security package to IBM Products label Feb 7, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Feb 7, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Feb 7, 2024
@paul-balchin-ibm paul-balchin-ibm changed the title Icon button bar New Component : Icon button bar Feb 14, 2024
@elycheea elycheea moved this from Backlog 🌋 to In progress in Carbon for IBM Products Feb 21, 2024
@paul-balchin-ibm paul-balchin-ibm linked a pull request Feb 26, 2024 that will close this issue
2 tasks
@elycheea elycheea closed this as completed Mar 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done 🚀 in Carbon for IBM Products Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: migration ➡️ Migration of Security package to IBM Products
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants