Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): update margin at max breakpoint #3824

Merged
merged 12 commits into from
Aug 27, 2019
Merged

fix(grid): update margin at max breakpoint #3824

merged 12 commits into from
Aug 27, 2019

Conversation

joshblack
Copy link
Contributor

Closes #3810

Update margin to 24px at max breakpoint

Changelog

New

Changed

  • Update max breakpoint margin to 24px

Removed

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for the-carbon-components ready!

Built with commit 8403a41

https://deploy-preview-3824--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-components-react ready!

Built with commit 8403a41

https://deploy-preview-3824--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-elements ready!

Built with commit 8403a41

https://deploy-preview-3824--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for the-carbon-components ready!

Built with commit a87458e

https://deploy-preview-3824--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-elements ready!

Built with commit a87458e

https://deploy-preview-3824--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for carbon-components-react ready!

Built with commit a87458e

https://deploy-preview-3824--carbon-components-react.netlify.com

@joshblack joshblack requested a review from a team August 26, 2019 15:55
@ghost ghost requested review from emyarod and mattrosno and removed request for a team August 26, 2019 15:55
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @joshblack!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just needs snapshot updates

@tw15egan tw15egan merged commit a2fd248 into master Aug 27, 2019
@asudoh asudoh deleted the joshblack-patch-3 branch August 28, 2019 03:06
@jnm2377 jnm2377 mentioned this pull request Sep 4, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grid] Grid max breakpoint's margin differs from docs
5 participants