From e3680e3876214f712fd2c0e59e4b444bcde03e5c Mon Sep 17 00:00:00 2001 From: Sierra Wetmore Date: Wed, 1 Mar 2023 16:21:54 -0600 Subject: [PATCH 1/3] refactor: convert TextAreaSkeleton to TypeScript --- ...extArea.Skeleton.js => TextArea.Skeleton.tsx} | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) rename packages/react/src/components/TextArea/{TextArea.Skeleton.js => TextArea.Skeleton.tsx} (67%) diff --git a/packages/react/src/components/TextArea/TextArea.Skeleton.js b/packages/react/src/components/TextArea/TextArea.Skeleton.tsx similarity index 67% rename from packages/react/src/components/TextArea/TextArea.Skeleton.js rename to packages/react/src/components/TextArea/TextArea.Skeleton.tsx index f6bc55c6b213..e83287e5d863 100644 --- a/packages/react/src/components/TextArea/TextArea.Skeleton.js +++ b/packages/react/src/components/TextArea/TextArea.Skeleton.tsx @@ -10,7 +10,21 @@ import React from 'react'; import cx from 'classnames'; import { usePrefix } from '../../internal/usePrefix'; -const TextAreaSkeleton = ({ hideLabel, className, ...rest }) => { +type ExcludedAttributes = ''; +export interface TextAreaSkeletonProps + extends Omit, ExcludedAttributes> { + /** + * Specify an optional className to add to the form item wrapper. + */ + className?: string; + + /** + * Specify whether the label should be hidden, or not + */ + hideLabel?: boolean; +} +const TextAreaSkeleton = (props: TextAreaSkeletonProps) => { + const { className, hideLabel, ...rest } = props; const prefix = usePrefix(); return (
From 4c15b78676b83ce00136469ecc2f25af5222761a Mon Sep 17 00:00:00 2001 From: Sierra Wetmore Date: Fri, 10 Mar 2023 09:22:53 -0600 Subject: [PATCH 2/3] chore: remove unneeded omit --- packages/react/src/components/TextArea/TextArea.tsx | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/react/src/components/TextArea/TextArea.tsx b/packages/react/src/components/TextArea/TextArea.tsx index cafb532af1f0..550e3f1e5652 100644 --- a/packages/react/src/components/TextArea/TextArea.tsx +++ b/packages/react/src/components/TextArea/TextArea.tsx @@ -17,12 +17,7 @@ import { useAnnouncer } from '../../internal/useAnnouncer'; import useIsomorphicEffect from '../../internal/useIsomorphicEffect'; import { useMergedRefs } from '../../internal/useMergedRefs'; -type ExcludedAttributes = ''; -export interface TextAreaProps - extends Omit< - React.InputHTMLAttributes, - ExcludedAttributes - > { +export interface TextAreaProps extends React.InputHTMLAttributes { /** * Provide a custom className that is applied directly to the underlying * `