Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y]: Aria-hidden incorrectly set on sidebar #9895

Closed
2 tasks done
samrobbins85 opened this issue Oct 19, 2021 · 0 comments · Fixed by #10087
Closed
2 tasks done

[a11y]: Aria-hidden incorrectly set on sidebar #9895

samrobbins85 opened this issue Oct 19, 2021 · 0 comments · Fixed by #10087
Assignees
@dakahn
Labels
component: ui-shell package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@samrobbins85
Copy link

Package

carbon-components-react

Browser

Chrome

Operating System

MacOS

Package version

7.45.0

Automated testing tool and ruleset

Axe Devtools

Assistive technology

No response

Description

The sidebar on desktop will have aria-hidden="true" even though it's open and so should be accessible

WCAG 2.1 Violation

No response

CodeSandbox example

https://codesandbox.io/s/ibm-sidenav-a11y-jo16k?file=/src/index.js

Steps to reproduce

  1. Open the codesandbox preview in a new window so that it is wide enough to show the sidenav expanded
  2. Inspect the nav component of the sidebar and see that it has aria-hidden="true" but is visible

Code of Conduct
@joshblack joshblack added component: ui-shell package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity and removed status: needs triage 🕵️‍♀️ labels Oct 19, 2021
@joshblack joshblack mentioned this issue Oct 19, 2021
Closed
61 tasks
@joshblack joshblack moved this to Todo in Design System Oct 28, 2021
@joshblack joshblack moved this from ⏱ Backlog to 🏗 In Progress in Design System Nov 5, 2021
@dakahn dakahn mentioned this issue Nov 11, 2021
Merged
@joshblack joshblack mentioned this issue Jan 4, 2022
Closed
46 tasks
@kodiakhq kodiakhq bot closed this as completed in #10087 Jan 27, 2022
Repository owner moved this from 🏗 In Progress to ✅ Done in Design System Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakahn dakahn

Labels
component: ui-shell package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(SideNav): add screen size check for aria-hidden value dakahn/carbon
3 participants
@joshblack @samrobbins85 @dakahn