Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VRT for DataTable #9272

Closed
30 tasks
tay1orjones opened this issue Jul 23, 2021 · 0 comments
Closed
30 tasks

Add VRT for DataTable #9272

tay1orjones opened this issue Jul 23, 2021 · 0 comments

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 23, 2021

This issue is to implement visual regression testing (VRT) for the following components by adding baseline Percy snapshot(s) inside a *-test.e2e.js file. More info and high level steps to complete can be found in the umbrella issue, #8911

At first glance this appears to be a large issue, though I think the complexity can be reduced significantly by rendering subsets of table "types" like what we have in the storybook. This way we can cover a large portion of data table functionality in fewer snapshots. I don't know that we need to individually snapshot every component.

  • default
  • with checkmark columns
  • with overflowmenu
  • with batch actions
  • with expansion
  • with filtering
  • with selection
  • with sorting

Though here is the full component list that these snapshots need to cover in some way:

  • DataTable
  • DataTableSkeleton
  • Table
  • TableActionList
  • TableBatchAction
  • TableBatchActions
  • TableBody
  • TableCell
  • TableContainer
  • TableExpandedRow
  • TableExpandHeader
  • TableExpandRow
  • TableHead
  • TableHeader
  • TableRow
  • TableSelectAll
  • TableSelectRow
  • TableToolbar
  • TableToolbarAction
  • TableToolbarContent
  • TableToolbarMenu
  • TableToolbarSearch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants