Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the eslint-plugin-testing-librarypackage to our eslint config #9048

Closed
Tracked by #8143 ...
joshblack opened this issue Jun 28, 2021 · 1 comment · Fixed by #9103 or #13528
Closed
Tracked by #8143 ...

Add the eslint-plugin-testing-librarypackage to our eslint config #9048

joshblack opened this issue Jun 28, 2021 · 1 comment · Fixed by #9103 or #13528
Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Milestone

Comments

@joshblack
Copy link
Contributor

joshblack commented Jun 28, 2021

We would like to add support for the testing library ESLint plugin to our eslint config: https://github.com/testing-library/eslint-plugin-testing-library

This issue will cover adding the plugin, enabling relevant rules, and scoping them to specific test files th at are currently using React Testing Library. This will be the tricky part of this change as most files are currently using enzyme. The strategy that we use to bring this in will need to allow us to incrementally update our files over to RTL and the eslint config should be able to reflect that.

@joshblack joshblack changed the title https://github.com/testing-library/eslint-plugin-testing-library Add the eslint-plugin-testing-librarypackage to our eslint config Jun 28, 2021
@tay1orjones
Copy link
Member

It looks like the config was added for this but the dependency was never actually added

@tay1orjones tay1orjones reopened this Mar 8, 2023
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Mar 8, 2023
@tay1orjones tay1orjones added this to the 2023 Q2 milestone Mar 15, 2023
@sstrubberg sstrubberg added the type: infrastructure 🤖 Issues relating to devops, tech debt, etc. label Mar 29, 2023
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🚦 In Review in Design System May 22, 2023
@kodiakhq kodiakhq bot closed this as completed in #13528 May 22, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Archived in project
4 participants