Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboBox: Support node in titleText attribute #7779

Closed
nmgokhale opened this issue Feb 10, 2021 · 0 comments · Fixed by #7785
Closed

ComboBox: Support node in titleText attribute #7779

nmgokhale opened this issue Feb 10, 2021 · 0 comments · Fixed by #7785
Assignees
@emyarod
Labels
proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡

Comments

@nmgokhale
Copy link

Summary

In Dropdown component titleText can be string | node . But in combobox component, titleText only accepts a string.

Can you please add support for node object in titleText attribute?

Justification

titleText is used as the label for ComboBox. By supporting node object, we can also add tooltips in the label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update listbox titleText proptypes to match Dropdown emyarod/carbon
3 participants
@emyarod @nmgokhale @dakahn