Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slider] Provide translateWithId #7141

Open
kccox opened this issue Oct 26, 2020 · 2 comments
Open

[slider] Provide translateWithId #7141

kccox opened this issue Oct 26, 2020 · 2 comments
Labels
component: slider proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡

Comments

@kccox
Copy link

kccox commented Oct 26, 2020

Summary

The Slider component should have a translateWithId property used to localize the slider tootips, similar to that provided for Dropdown, MultiSelect, NumberInput, and others. This would primarily be development as the design should be similar to that of the other components.

Justification

The Slider component displays tooltips for some error conditions. Customers need the tooltip messages to be localized.

Desired UX and success metrics

When the user hovers over the slider and a tooltip is displayed, the message should use the language of the browser's locale setting.

"Must have" functionality

There are at least four slider tooltips:

  • "Please select a value that is no less than MIN" when the value is less than the slider minimum
  • "Please select a value that is no more than MAX" when the value is more than the slider maximum
  • "Please select a valid value. The two nearest values are V1 and V2" when the value does not match the slider's step constraint
  • "Please enter a number" when the value is non-numeric.

It should be possible to localize all of these, preferably with the same translateWithId function interface that other components provide. Also, if any other tooltips are used by the slider, it should be possible to localize them with the same mechanism.

The MIN, MAX, V1, and V2 values are message parameters. If that is difficult to support with the translateWithId function, it would be acceptable to omit the parameters and use a more general message such as "Please select a value within the range of the slider".

Specific timeline issues / requests

There is no specific timeline for completion.

Available extra resources

I can not give any resources to this effort at this time.

@dakahn dakahn added proposal: open This request has gone through triaging. We're determining whether we take this on or not. component: slider and removed status: needs triage 🕵️‍♀️ labels Oct 26, 2020
@dakahn
Copy link
Contributor

dakahn commented Oct 26, 2020

Thank you for submitting 👍 Added to our proposal backlog. Check back here for updates soon.

@vpicone vpicone added the proposal: accepted This request has gone through triaging and we are accepting PR's against it. label Jun 21, 2021
@vpicone
Copy link
Contributor

vpicone commented Jun 21, 2021

This looks like something we'd definitely want to implement consistently between components in v11.

@vpicone vpicone removed the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Jun 21, 2021
@vpicone vpicone mentioned this issue Jun 21, 2021
@tay1orjones tay1orjones moved this to Accepted in Roadmap Aug 24, 2022
@sstrubberg sstrubberg moved this from Accepted to Dev Heavy in Roadmap Oct 11, 2022
@sstrubberg sstrubberg moved this from Dev Heavy to Slider in Roadmap Oct 13, 2022
@sstrubberg sstrubberg moved this from Slider to Backlog in Roadmap Dec 12, 2022
@sstrubberg sstrubberg moved this from Backlog to Icebox in Roadmap Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡
Projects
Status: Later 🧊
Development

No branches or pull requests

3 participants