Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: invalid throws errors #6808

Closed
1 of 2 tasks
rvsia opened this issue Sep 10, 2020 · 0 comments · Fixed by #6809
Closed
1 of 2 tasks

Slider: invalid throws errors #6808

rvsia opened this issue Sep 10, 2020 · 0 comments · Fixed by #6809

Comments

@rvsia
Copy link
Contributor

rvsia commented Sep 10, 2020

Title line template: [Title]: Brief description

When passing invalid to Slider an error is thrown

Warning: Received `true` for a non-boolean attribute `invalid`.

If you want to write it to the DOM, pass a string instead: invalid="true" or invalid={value.toString()}.
    in div (created by Slider)
    in div (created by Slider)
    in div (created by Slider)
    in Slider (created by Container)

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Is this issue related to a specific component?

Slider

What did you expect to happen? What happened instead? What would you like to
see changed?

No error shown.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

The latest stable.

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

https://github.com/data-driven-forms/react-forms
will be used in https://github.com/ManageIQ/manageiq-ui-classic
No date

Steps to reproduce the issue

  1. Pass invalid={true} to Slider
  2. Check console log for the error
  • React:

https://codesandbox.io/s/eager-snyder-lmoot?fontsize=14&hidenavigation=1&theme=dark

Additional information

  • Notes

I will make a PR myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant