-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conduct prop audit as a team #6690
Comments
ComponentsAccordion
AccordionItem
Breadcrumb
BreadcrumbItem
Button
Checkbox
CodeSnippet
ComboBox
ComposedModal
ModalHeader
ModalBody
ModalFooter
ContentSwitcher
Copy
CopyButton
DataTable
Table
TableActionList
TableBatchAction
TableBatchActions
TableBody
TableCell
TableContainer
TableExpandHeader
TableExpandRow
TableExpandedRow
TableHead
TableHeader
TableRow
TableSelectAll
TableSelectRow
TableToolbar
TableToolbarAction
TableToolbarContent
TableToolbarSearch
TableToolbarMenu
DatePicker
DatePickerInput
Dropdown
ErrorBoundary
FileUploader
Filename
FileUploaderButton
FileUploaderDropContainer
FileUploaderItem
Form
FluidForm
FormGroup
FormItem
FormLabel
Grid
Row
Column
Icon
InlineLoading
Link
ListItem
Loading
Modal
ModalWrapper
MultiSelect
ToastNotification
InlineNotification
NotificationActionButton
NotificationButton
NotificationTextDetails
OrderedList
OverflowMenuItem
Pagination
PaginationNav
ProgressIndicator
ProgressStep
RadioButtonGroup
Search
SearchFilterButton
SearchLayoutButton
Select
SelectItem
SelectItemGroup
Switch
Slider
StructuredListWrapper
StructuredListHead
StructuredListBody
StructuredListRow
StructuredListInput
StructuredListCell
Tab
TabContent
Tabs
Tag
TextArea
TextInput
Tile
ClickableTile
SelectableTile
ExpandableTile
TileAboveTheFoldContent
TileBelowTheFoldContent
RadioTile
TileGroup
TimePicker
TimePickerSelect
Toggle
ToggleSmall
Toolbar
ToolbarItem
ToolbarTitle
ToolbarOption
ToolbarSearch
TooltipDefinition
TooltipIcon
UnorderedList
SkeletonText
SkeletonPlaceholder
DataTableSkeleton
AccordionSkeleton
BreadcrumbSkeleton
ButtonSkeleton
CheckboxSkeleton
CodeSnippetSkeleton
DropdownSkeleton
FileUploaderSkeleton
NumberInputSkeleton
PaginationSkeleton
ProgressIndicatorSkeleton
RadioButtonSkeleton
SearchSkeleton
SelectSkeleton
SliderSkeleton
StructuredListSkeleton
TabsSkeleton
TagSkeleton
TextAreaSkeleton
TextInputSkeleton
ToggleSkeleton
ToggleSmallSkeleton
IconSkeleton
DatePickerSkeleton
PageSelector
Unstable_Pagination
Content
Header
HeaderContainer
HeaderGlobalAction
HeaderGlobalBar
HeaderMenuButton
HeaderMenuItem
HeaderName
HeaderNavigation
HeaderPanel
HeaderSideNavItems
Switcher
SwitcherItem
SwitcherDivider
SkipToContent
SideNav
SideNavDetails
SideNavFooter
SideNavHeader
SideNavIcon
SideNavItem
SideNavItems
SideNavLink
SideNavLinkText
SideNavMenuItem
SideNavSwitcher
|
Frequency
|
@joshblack This is a great initiative. Some thoughts regarding... shortening
|
@metonym thanks for the input! Love these ideas. Only one note, for the shortening prop name step I believe we'll move forward with We can definitely do this on a case-by-case basis, but might make more sense just to have one convention across the codebase so the API becomes more guess-able instead of being component-specific. |
Going to close this in favor specific audit lists 👀 |
This issue is to conduct a prop audit as a team and determine next steps for prop conventions or renames for the next major release.
Topics to discuss:
className
ref
open
vsisOpen
render*
propsaria-label
vslabel
size
variantssize
prop, or is the size itself a prop?Related issues:
The text was updated successfully, but these errors were encountered: