Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WarningAltFilled icon needs [data-icon-path="inner-path"] #5919

Closed
janhassel opened this issue Apr 23, 2020 · 4 comments
Closed

WarningAltFilled icon needs [data-icon-path="inner-path"] #5919

janhassel opened this issue Apr 23, 2020 · 4 comments

Comments

@janhassel
Copy link
Member

Since the WarningAltFilled icon will likely be colored in $support-03, there needs to be a way to access the inner path (exclamation mark) to color it black.

WarningFilled already supports this by providing a path that is transparent by default and can be accessed with the [data-icon-path="inner-path"] selector.

@joshblack
Copy link
Contributor

cc @conradennis

@janhassel
Copy link
Member Author

Hi, @conradennis @joshblack 👋
Just wanted to check in and ask if there are any updates. This is blocking #5918.

@conradennis
Copy link
Contributor

conradennis commented Jul 10, 2020

@janhassel @joshblack hi sorry for the delay, just seeing this now! Yes this was resolved in April actually with PR #5888 which closed #4053

@janhassel
Copy link
Member Author

@conradennis Ah, I haven't noticed that, sorry. In that case, I'll go ahead and close this issue. Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants