Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default tag now includes button styles #5133

Closed
joshblack opened this issue Jan 22, 2020 · 0 comments · Fixed by #5140
Closed

Default tag now includes button styles #5133

joshblack opened this issue Jan 22, 2020 · 0 comments · Fixed by #5140
Labels
component: tags package: react carbon-components-react role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@joshblack
Copy link
Contributor

We updated the tag markup for filter tags to include a button but unfortunately this impacts the default tags and adds in interactive behavior when this might not be intended. This issue is to update the tag component such that interactive tags are only added when the tag is the filter variant.
@joshblack joshblack added type: bug 🐛 role: dev 🤖 package: react carbon-components-react component: tags impact: high 😱 severity: 1 https://ibm.biz/carbon-severity severity: 2 https://ibm.biz/carbon-severity and removed severity: 1 https://ibm.biz/carbon-severity labels Jan 22, 2020
@dakahn dakahn mentioned this issue Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tags package: react carbon-components-react role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tag): add default cursor to non-filter tag
1 participant
@joshblack