-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatePicker]: When typing date range picker chooses invalid date #3832
Comments
I tested in the latest version of Carbon, and received similar results if I hit the enter button in this state |
Hi 👋 thank you for reporting - A quick question, is this against our vanilla variant or against our React variant? |
this happens in both, I think it is related to flatpickr |
Perhaps we should bring this to their attention and see if this is working as they intended or it is a bug |
@scottdickerson Do you see the issue at http://react.carbondesignsystem.com/?path=/story/datepicker--single-with-calendar or https://the-carbon-components.netlify.com/component/date-picker--single.html? I'm asking this because I couldn't see the problem at neither of them. Thanks! |
I do, if you're looking at August in the calendar, type 08/0/2019 and hit enter you'll see it switch |
Thanks @scottdickerson. I see enter key is the trigger. Reported at flatpickr/flatpickr#1927. |
@asudoh The problem is not only happening if you set an invalid date. |
You are right @georginaso for the additional scenario. As mentioned, it's how Flatpickr works. That said, if the Flatpickr author sees many requests for "update-date-as-blur" or a like, e.g. by adding 👍 to |
@asudoh There is a related issue already reported on the Flatpickr repo, but don't seem that they are going to fix it 😞: flatpickr/flatpickr#1551 |
Closing this as it seems its a Flatpickr issue and not an issue on our end. |
If we are editing the date and it's showing 08/03/2019. when we show 08/0/2019 in the date picker, the range switches to July 31st. It shouldn't update since 08/0/2019 is an invalid date
The text was updated successfully, but these errors were encountered: