Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVT 1 - React for the Header Base w/SideNav UI Shell has DAP violations #3578

Closed
snidersd opened this issue Jul 30, 2019 · 1 comment
Closed

AVT 1 - React for the Header Base w/SideNav UI Shell has DAP violations #3578

snidersd opened this issue Jul 30, 2019 · 1 comment
Labels
component: ui-shell severity: 1 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@snidersd
Copy link

Environment

macOS Mojave version 10.14.5
Chrome Version 75.0.3770.100 (Official Build) (64-bit)
Carbon v10 - React
DAP - July 2019 Ruleset

Detailed Description

Run DAP on the Header Base w/SideNav UI Shell. The following 3 violations:
HeaderSideNav-1
HeaderSideNav-2
@snidersd snidersd changed the title AVT 1 - React or the Header Base w/SideNav UI Shell has DAP violations AVT 1 - React for the Header Base w/SideNav UI Shell has DAP violations Jul 30, 2019
@aledavila aledavila added this to the UI Shell - A11y Project Team milestone Sep 30, 2019
@dakahn dakahn added priority: high severity: 1 https://ibm.biz/carbon-severity labels Sep 30, 2019
@dakahn dakahn modified the milestones: UI Shell - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@dakahn dakahn mentioned this issue Nov 22, 2019
Closed
@joshblack
Copy link
Contributor

It seems like the contrast violation refers to our skip to content widget:

Screen Shot 2019-12-05 at 11 33 38 AM

This has the following contrast:

Screen Shot 2019-12-05 at 11 34 10 AM

The second issue is related to the demo environment because storybook wraps our work in a <div> with role="main"

@joshblack joshblack reopened this Dec 6, 2019
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
@hixio-mh hixio-mh mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ui-shell severity: 1 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mattrosno @joshblack @aledavila @snidersd @dakahn