Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: combo button #3371

Closed
kaylarakower opened this issue May 23, 2019 · 13 comments · Fixed by #13224
Closed

Contribution: combo button #3371

kaylarakower opened this issue May 23, 2019 · 13 comments · Fixed by #13224
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11

Comments

@kaylarakower
Copy link

kaylarakower commented May 23, 2019

Name: Contextual menu Combo button

Research: We have three actions a user can take to complete their tasks from our local navigation. If we displayed all three by default, the buttons take up the majority of the navigation.
The contextual menu was designed for our specific use case and tested positively in usability testing.

command_menu

Sketch file: https://ibm.box.com/s/hxoc500nk0i5l57evl308kf93c3jbt37

Contributing team: DrupalOne

Contributing designer: Kayla Rakower, [email protected]

Contributing developer: Chris Wilson, [email protected]

@kaylarakower kaylarakower changed the title Command menu Contribution: Command menu May 23, 2019
@kaylarakower kaylarakower changed the title Contribution: Command menu Contribution: Context menu May 28, 2019
@kaylarakower kaylarakower changed the title Contribution: Context menu Contribution: ContextUAL menu May 28, 2019
@kaylarakower kaylarakower changed the title Contribution: ContextUAL menu Contribution: Contextual menu May 28, 2019
@aagonzales
Copy link
Member

aagonzales commented Jun 20, 2019

@kaylarakower is the button beside the menu also a part of the component? What the relationship of the button and menu? How is this different than an overflow menu or a dropdown?
image

Or is the component the whole piece? What do the pieces on the far left do?
image

@kaylarakower
Copy link
Author

kaylarakower commented Jul 9, 2019

@aagonzales aagonzales transferred this issue from carbon-design-system/carbon-contribution Jul 11, 2019
@aagonzales
Copy link
Member

aagonzales commented Jul 22, 2019

✅ Experimental status approved

Moving forward this component will go into experimental to start with. I have approved @kaylarakower latest designs. Her developers will be building and contributing this component.

@kaylarakower
Copy link
Author

Update: My team will not be able to contribute the development of this feature, @aagonzales please add to dev backlog

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 30, 2019
@stale stale bot closed this as completed Sep 2, 2019
@aagonzales aagonzales reopened this Nov 15, 2019
@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Nov 15, 2019
@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Dec 15, 2019
@aagonzales aagonzales removed the status: inactive Will close if there's no further activity within a given time label Dec 16, 2019
@joshblack joshblack added proposal: accepted This request has gone through triaging and we are accepting PR's against it. proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Jan 14, 2020
@aagonzales aagonzales changed the title Contribution: Contextual menu Contribution: combo button Feb 20, 2020
@carbon-design-system carbon-design-system deleted a comment from stale bot Feb 28, 2020
@carbon-design-system carbon-design-system deleted a comment from stale bot Feb 28, 2020
@carbon-design-system carbon-design-system deleted a comment from stale bot Feb 28, 2020
@carmacleod
Copy link
Contributor

carmacleod commented Nov 3, 2020

Our team has something similar to your menu button. Ours is a hacked up combination of overflow menu and primary button. It works "ok", but it does not have focus styling consistent with other Carbon primary buttons. Yours looks good so far! Our team could definitely use something like your menu button! (Of course, we would want to keep our plus sign icon. :) )
image

@carmacleod
Copy link
Contributor

carmacleod commented Nov 3, 2020

Also I'd like to make sure that you consider the ARIA markup needed to make a menu button accessible to screen reader users. Here's the "Menu Button" pattern in the APG. Please read through the "Keyboard Interaction" section and the "WAI-ARIA Roles, States, and Properties" section in the Pattern description. There are 3 examples - I think your menu button would be closest to the 2nd example (although I am not a fan of opening the menu on hover!). Note that the Pattern description is more important than the examples, because each example just shows one way to implement the pattern, but there are certainly other valid ways to do it.

@pirupius
Copy link

pirupius commented Oct 21, 2021

@carmacleod is there a chance your work around is documented online? We have a similar need and wanted a work around as we wait for this to be added to carbon. Can u please kindly respond to this discussion #9905

@laurenmrice
Copy link
Member

laurenmrice commented Oct 19, 2022

  • This is the updated design and specs for Combo button and Menu button using v11 tokens.

Combo button

  • Only implemented using the Primary button.
  • Offered in Large, Medium, and Small sizes.

Combo button specs

Menu button

  • Implemented with the Primary, Secondary, Ghost, and Tertiary buttons.
  • Offered in Large, Medium, and Small sizes.

Menu button specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

10 participants