Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] Fix Adjacent ellipses in PaginationNav #17628

Closed
2 tasks done
thyhmdo opened this issue Oct 1, 2024 · 2 comments · Fixed by #17779
Closed
2 tasks done

[Pagination] Fix Adjacent ellipses in PaginationNav #17628

thyhmdo opened this issue Oct 1, 2024 · 2 comments · Fixed by #17779

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Oct 1, 2024

Bug issue: #15830
Closes #15830

Tasks

Preview Give feedback

Design Specs

Image

@janhassel
Copy link
Member

I already briefly shared this over in #15830 (comment) but I again wanna voice a concern that surfaced during user testing with the proposed design update: the number of total buttons would change depending on the location of the current page. This means that the entire component grows and shrinks in size and can cause misclicks by the user.

In the first scenario depicted in these specs:
Image

If the user wants to reach page 4, they're likely not going through the OverflowMenu but just click on the right caret twice. After the first click, the position of the right caret changes though and the user would click on page 10.

This is a huge usability issue that users encountered during our testing of this design. That's why we opted to keep the number of buttons the same no matter what the current page is. I urge you to reconsider these specs.

@thyhmdo
Copy link
Member Author

thyhmdo commented Oct 7, 2024

@janhassel thanks for the review. I'll take a look at it and update it soon.

@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants