Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab should allow styling tab content #1739

Closed
nelsonchen90 opened this issue Feb 7, 2019 · 2 comments
Closed

Tab should allow styling tab content #1739

nelsonchen90 opened this issue Feb 7, 2019 · 2 comments

Comments

@nelsonchen90
Copy link
Contributor

nelsonchen90 commented Feb 7, 2019

Summary

Both Tabs and Tab accept className to style the navigation part of the component. But when it comes to styling the tab content area, the only way is to style elements within the content area, not on the content area.

Clarify if you are asking for both design and development, or just design, or just development.
just Development

Justification

unless there is specific reason not to allow changing the styles of .tab-content element, we should allow consumer/application to specify what they want.

one use case is scrolling only on the content area by using flex. we should be able to just add overflow-y: auto to the content div.
image

"Must have" functionality

allow adding css class to the content area div

@nelsonchen90
Copy link
Contributor Author

@lovemecomputer FYI

@asudoh
Copy link
Contributor

asudoh commented Feb 8, 2019

HI @nelsonchen90 our vanilla/React tabs/tab components themselves doesn't define any markup for tab panels. It's app up to application. Please see https://github.com/IBM/carbon-components/blob/v9.62.0/src/components/tabs/tabs.hbs#L20-L27 and https://github.com/IBM/carbon-components-react/blob/v6.74.0/src/components/Tabs/Tabs-story.js#L44 for more details. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants