-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs: Remove max-width from Tab #11766
Comments
|
@aagonzales should this be an option, or should it be that all tabs no longer have a max width and will never truncate? |
If it helps @tay1orjones, here's the comment that I made this issue from #11765 (review) |
hmm I want to say let's kill max width completely, mostly for the sake of translation etc. Hopefully, designers and content designers are creating tab names with intentions. My one hesitation around removing it altogether would be in regards to user or system generate tab names that could become excessively long. I'm not sure how likely this use-case would be, its probably not common. If we remove it, would a team be able to easily place a max-width if this happened to be a recurring problem in their product? |
Thanks @abbeyhrt! @aagonzales Yes, if we remove it altogether it could be a significant visual change in apps where they're relying heavily on truncation. It would be very easy for them to add it back in within their own app's stylesheet though. |
This issue is for simply removing the max-width property from Tab to allow them to flow to 100% the width of their content.
The text was updated successfully, but these errors were encountered: