Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that size changes work as expected across components #10295

Closed
36 tasks done
Tracked by #10316
joshblack opened this issue Dec 15, 2021 · 2 comments
Closed
36 tasks done
Tracked by #10316

Verify that size changes work as expected across components #10295

joshblack opened this issue Dec 15, 2021 · 2 comments
Assignees
Milestone

Comments

@joshblack
Copy link
Contributor

joshblack commented Dec 15, 2021

In v11, we standardized how our size prop worked across components. This issue is for verifying that these work as intended across our components. The standard for the size prop is that it is defined as follows:

ComponentName.propTypes = {
  size: PropTypes.oneOf([/* sizes */]),
};

Where sizes contains a set of the following values:

  • sm
  • md
  • lg
  • xl

Specifically, we need to go through the following components:

@tay1orjones
Copy link
Member

A note on size default values:

In #10532 it was brought up that v10's md is the same value as v11's lg. In these cases we can either update the defaults to be a conditional based off the feature flag or simply wait to redefine the defaults until v11.

@tay1orjones
Copy link
Member

Note on file-uploader, we need to remove the field sizing from styles and from the props. Fileuploader doesn't have a next version yet to accompany this.

Repository owner moved this from 🏗 In Progress to ✅ Done in Design System Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants