fix(OverflowMenu): remove handlers from icon props (#9963)

* fix(OverflowMenu): remove handlers from icon props Closes #9962 * fix: data table overflow menu snap Co-authored-by: Josefina Mancilla <[email protected]>
carbon-design-system · Nov 2, 2021 · f24e5f9 · f24e5f9
1 parent 26c053f
commit f24e5f9
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 20 deletions.
diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2522,16 +2522,12 @@ exports[`DataTable should render 1`] = `
                           <ForwardRef(Settings16)
                             aria-label="Settings"
                             className="bx--overflow-menu__icon"
-                            onClick={[Function]}
-                            onKeyDown={[Function]}
                           >
                             <Icon
                               aria-label="Settings"
                               className="bx--overflow-menu__icon"
                               fill="currentColor"
                               height={16}
-                              onClick={[Function]}
-                              onKeyDown={[Function]}
                               preserveAspectRatio="xMidYMid meet"
                               viewBox="0 0 16 16"
                               width={16}
@@ -2543,8 +2539,6 @@ exports[`DataTable should render 1`] = `
                                 fill="currentColor"
                                 focusable="false"
                                 height={16}
-                                onClick={[Function]}
-                                onKeyDown={[Function]}
                                 preserveAspectRatio="xMidYMid meet"
                                 role="img"
                                 viewBox="0 0 16 16"
@@ -3586,16 +3580,12 @@ exports[`DataTable sticky header should render 1`] = `
                           <ForwardRef(Settings16)
                             aria-label="Settings"
                             className="bx--overflow-menu__icon"
-                            onClick={[Function]}
-                            onKeyDown={[Function]}
                           >
                             <Icon
                               aria-label="Settings"
                               className="bx--overflow-menu__icon"
                               fill="currentColor"
                               height={16}
-                              onClick={[Function]}
-                              onKeyDown={[Function]}
                               preserveAspectRatio="xMidYMid meet"
                               viewBox="0 0 16 16"
                               width={16}
@@ -3607,8 +3597,6 @@ exports[`DataTable sticky header should render 1`] = `
                                 fill="currentColor"
                                 focusable="false"
                                 height={16}
-                                onClick={[Function]}
-                                onKeyDown={[Function]}
                                 preserveAspectRatio="xMidYMid meet"
                                 role="img"
                                 viewBox="0 0 16 16"

diff --git a/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap b/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
@@ -79,16 +79,12 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
             <ForwardRef(Download16)
               aria-label="Add"
               className="bx--overflow-menu__icon"
-              onClick={[Function]}
-              onKeyDown={[Function]}
             >
               <Icon
                 aria-label="Add"
                 className="bx--overflow-menu__icon"
                 fill="currentColor"
                 height={16}
-                onClick={[Function]}
-                onKeyDown={[Function]}
                 preserveAspectRatio="xMidYMid meet"
                 viewBox="0 0 16 16"
                 width={16}
@@ -100,8 +96,6 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
                   fill="currentColor"
                   focusable="false"
                   height={16}
-                  onClick={[Function]}
-                  onKeyDown={[Function]}
                   preserveAspectRatio="xMidYMid meet"
                   role="img"
                   viewBox="0 0 16 16"

diff --git a/packages/react/src/components/OverflowMenu/OverflowMenu.js b/packages/react/src/components/OverflowMenu/OverflowMenu.js
@@ -533,8 +533,6 @@ class OverflowMenu extends Component {
     );
 
     const iconProps = {
-      onClick: this.handleClick,
-      onKeyDown: this.handleKeyDown,
       className: overflowMenuIconClasses,
       'aria-label': iconDescription,
     };