Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified Tooltip hover, behavior missing from Icon Library page #914

Closed
chrisconnors-ibm opened this issue Feb 17, 2020 · 4 comments · Fixed by #916
Closed

Specified Tooltip hover, behavior missing from Icon Library page #914

chrisconnors-ibm opened this issue Feb 17, 2020 · 4 comments · Fixed by #916
Labels
severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@chrisconnors-ibm
Copy link
Contributor

chrisconnors-ibm commented Feb 17, 2020

Navigate to https://www.carbondesignsystem.com/guidelines/icons/library

Hover over a card to reveal the action buttons

Hover over Download or Code buttons

Expected: Behavior described in initial issue

  1. No actions icon are shown by default
  2. When a user hovers or focuses on an icon tile, download and copy functions will appear.
  3. When hovering/focusing on an individual action icon a tooltip will appear.
    • "Download SVG"
    • "Copy <icon-name />"

Actual:
☑️ No actions icon are shown by default
☑️ When a user hovers or focuses on an icon tile, download and copy functions will appear.
❌ When hovering/focusing on an individual action icon:

  • [download] "Download <icon-name />" in an alt-tag
  • [copy] no hover behavior
    icon_card
@vpicone
Copy link
Contributor

vpicone commented Feb 17, 2020

@chrisconnors-ibm @aagonzales if we have both a Copy <icon-name /> and a Copied! alert they're going to conflict with one another. Our CopyButton component uses the native browser tooltip for the hover tooltip.

We need to indicate that it was copied successfully though.

@chrisconnors-ibm
Copy link
Contributor Author

Our CopyButton component uses the native browser tooltip for the hover tooltip.

Right now, nothing happens when you hover over the copy button.

@aagonzales
Copy link
Member

I mean I don't think it would hurt to show a stronger tooltip sooner since they're standalone icons.
Like on slack the tooltip appears immediately.

Feb-17-2020 15-18-04

@jnm2377 jnm2377 added the severity: 2 https://ibm.biz/carbon-severity label Feb 17, 2020
@vpicone
Copy link
Contributor

vpicone commented Feb 17, 2020

@chrisconnors-ibm I was referring to the CopyButton component from Carbon: https://react.carbondesignsystem.com/?path=/story/copybutton--default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants