Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(toggle): Update the Style tab with the latest content template #4446

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Kritvi-bhatia17
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 commented Jan 28, 2025

Closes #4216

Update the Style tab with the latest content template and fixed a few more sections.

Changelog

Changed

  • Converted all the "action text" to "state text", both in images and texts.
  • Updated a few images to change "Label" to "Reminder".
  • There are two color tokens in this table that do not have the $ before the token name, but they need it.
  • In the default toggle structure table, updated the handle size in the image, as it is marked incorrectly (does not match with the table).
  • In the small toggle structure table, added a row for the Label text.
  • The image caption should not have a period after it.
  • Fixed a few typos

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Jan 30, 2025 1:50pm

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title doc(toggle): Update the Style tab with the usage content template doc(toggle): Update the Style tab with the latest content template Jan 28, 2025
@Kritvi-bhatia17 Kritvi-bhatia17 marked this pull request as ready for review January 28, 2025 15:54
@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners January 28, 2025 15:54
@Kritvi-bhatia17 Kritvi-bhatia17 self-assigned this Jan 29, 2025
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size section
The column header for Height should read: "Height (px/rem)" according to the content template.

src/pages/components/toggle/style.mdx Outdated Show resolved Hide resolved
src/pages/components/toggle/style.mdx Show resolved Hide resolved
src/pages/components/toggle/style.mdx Outdated Show resolved Hide resolved
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

redeploying the vercel build

Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Kritvi-bhatia17
Copy link
Contributor Author

Kritvi-bhatia17 commented Feb 3, 2025

Hi dev, could you please help with merging the PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Toggle]: Style tab
5 participants