Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images need correcting on edges as PNG. Recommend exporting these as SVG. #2489

Closed
mjabbink opened this issue Aug 10, 2021 · 9 comments · Fixed by #2668
Closed

Images need correcting on edges as PNG. Recommend exporting these as SVG. #2489

mjabbink opened this issue Aug 10, 2021 · 9 comments · Fixed by #2668
Assignees

Comments

@mjabbink
Copy link
Contributor

mjabbink commented Aug 10, 2021

IN exporting to PNG the edges of the artwork are creating lighter aliasing which is not good when they are on dark backgrounds. It causes little borders to show up which looks amateur.

https://www.carbondesignsystem.com/
https://www.carbondesignsystem.com/whats-happening/news-and-articles/

examples of current

1_G2OdkbpTc6xbotnyKWyR8Q.png

1_mIJ84K3Iazci2fW9xvFR4Q.png

1_qgWhvGf0kwCaq7nylYm73w.png

Details

Screen Shot 2021-08-10 at 12.03.26 PM.png

Screen Shot 2021-08-10 at 12.01.26 PM.png

Screen Shot 2021-08-10 at 12.01.16 PM.png

Screen Shot 2021-08-10 at 11.58.33 AM.png

Screen Shot 2021-08-10 at 11.58.17 AM.png

@mjabbink
Copy link
Contributor Author

@jeanservaas @thyhmdo These images need to be either exported better or corrected in PS so the edges do not have the crappy aliasing OR better yet, these types of images can be SVG since they are vector and will look great.

@thyhmdo
Copy link
Member

thyhmdo commented Aug 12, 2021

I did not make these, I think Jeannie has either PS or Illustration files?

@mjabbink
Copy link
Contributor Author

@jeanservaas Can you provide Thy with your Ai files for these. I would like to resolve this issue since it looks lame on mobile

@mjabbink
Copy link
Contributor Author

I think these need to be SVGs to avoid this or you all have to pay special attention to the borders of the images once you make them PNGs because it looks like they get compressed which may cause this.

@thyhmdo
Copy link
Member

thyhmdo commented Aug 31, 2021

Just sent Josh these images for update
https://ibm.ent.box.com/folder/144694477942

@mjabbink
Copy link
Contributor Author

mjabbink commented Oct 5, 2021

@alisonjoseph @tay1orjones Let’s please get this issue closed this sprint.

@sstrubberg
Copy link
Member

Reached out to @aledavila and @thyhmdo directly on Slack earlier this week.

Reposting here for clarity the images that we are pulling are coming directly from Medium through the MediumPosts component I made for the Gatsby Theme. In other words, we aren't hosting these images, Medium is. The authors of their respective articles will need to update accordingly.

@sstrubberg
Copy link
Member

We tried to upload the SVG's to Medium and it turns out they aren't supported.. womp womp...
image

So now we need to make a decision, go back to the old, manual way of updating this content, where we control the source imagery, or do we use the automated component that just pulls in the content automatically at build time with the unfortunate side effect of these artifacts happening.

Is there a way we can still use a PNG and get the same quality? Does it have to be SVG?

@joshblack joshblack moved this from ⏱ Backlog to 🏗 In Progress in Design System Dec 3, 2021
@joshblack joshblack moved this from 🏗 In Progress to ⏱ Backlog in Design System Dec 3, 2021
@aledavila
Copy link
Contributor

I'll surface this again. What is the consensus on this since we cannot upload svgs to medium.

@mjabbink @jeanservaas @sstrubberg

@joshblack joshblack moved this from ⏱ Backlog to 🏗 In Progress in Design System Dec 6, 2021
@joshblack joshblack assigned joshblack and unassigned aledavila Dec 14, 2021
@kodiakhq kodiakhq bot closed this as completed in #2668 Dec 15, 2021
Repository owner moved this from 🏗 In Progress to ✅ Done in Design System Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants