Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pattern] status indicator grid issues #2435

Closed
jeanservaas opened this issue Jul 2, 2021 · 15 comments · Fixed by #2681
Closed

[pattern] status indicator grid issues #2435

jeanservaas opened this issue Jul 2, 2021 · 15 comments · Fixed by #2681

Comments

@jeanservaas
Copy link
Collaborator

Grid issues:

Also, the the status icon and status shape tables are not on grid, to the spec that was given. And they're not consistently off grid either.

See misalignment:

image

Table specs: (See complete table specs at breakpoints here)
#2199

To do:

  • @vpicone we need to align the tables to the specs that were in the other issue; I didn't catch these discrepancies in my review
@mjabbink
Copy link
Contributor

Let’s not forget about this grid, alignment fix. This should be addressed in the next sprint.

@mjabbink
Copy link
Contributor

@alisonjoseph @joshblack Please make sure this is added to this sprint. This one can't slip through the cracks.

@alisonjoseph
Copy link
Member

@mjabbink @jeanservaas I'll get @vpicone to chime in here also, but from my understanding this is using the Structured List component from Carbon which is not grid-aware. It would likely require a complete re-write of that component or a new one to be able to figure out a way to get this on-grid. That being said, I see the issue especially where the different tables don't align to each other, and wonder if there's something we could do to make it a little better until we have time to prioritize a new component?

@mjabbink
Copy link
Contributor

mjabbink commented Aug 4, 2021

@alisonjoseph @vpicone If the first two columns of icons are the same shouldn't those at least be the same in each structuralist? maybe as a first fix, those icons columns could be the same which would make a difference.

another issue
@alisonjoseph @jeanservaas @vpicone — I discovered in mobile the dark theme column is not visible or turned off. Should that be a separate issue or keep it here?

Screen Shot 2021-08-04 at 11 21 52 AM

@mjabbink
Copy link
Contributor

@alisonjoseph @joshblack @aagonzales Please include this in the next sprint.

@mjabbink

This comment has been minimized.

@jeanservaas

This comment has been minimized.

@mjabbink

This comment has been minimized.

@jeanservaas
Copy link
Collaborator Author

Here are full red lines for the status indicator table component:

Sketch file

042721_CarbonPatterns_IconTable 2.sketch.zip

@jnm2377

This comment has been minimized.

@mjabbink

This comment has been minimized.

@jnm2377

This comment has been minimized.

@mjabbink

This comment has been minimized.

@mjabbink

This comment has been minimized.

@alisonjoseph

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants