-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pattern] status indicator grid issues #2435
Comments
Let’s not forget about this grid, alignment fix. This should be addressed in the next sprint. |
@alisonjoseph @joshblack Please make sure this is added to this sprint. This one can't slip through the cracks. |
@mjabbink @jeanservaas I'll get @vpicone to chime in here also, but from my understanding this is using the Structured List component from Carbon which is not grid-aware. It would likely require a complete re-write of that component or a new one to be able to figure out a way to get this on-grid. That being said, I see the issue especially where the different tables don't align to each other, and wonder if there's something we could do to make it a little better until we have time to prioritize a new component? |
@alisonjoseph @vpicone If the first two columns of icons are the same shouldn't those at least be the same in each structuralist? maybe as a first fix, those icons columns could be the same which would make a difference. another issue |
@alisonjoseph @joshblack @aagonzales Please include this in the next sprint. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Here are full red lines for the status indicator table component: Sketch file |
Grid issues:
Also, the the status icon and status shape tables are not on grid, to the spec that was given. And they're not consistently off grid either.
See misalignment:
Table specs: (See complete table specs at breakpoints here)
#2199
To do:
The text was updated successfully, but these errors were encountered: