-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pattern] status indicator content fixes #2430
Comments
@vpicone This is a high-priority update to avoid mass confusion. |
Table alignment and grid fixes a must. |
Let me know whenever the content is ready, I can update the yaml and add the images. |
@vpicone The content is ready for icon update and color updates. @jeanservaas can confirm but those are Ready to Go Cotton-Eyed Joe. Grid/Table alignments can happen next sprint I reckon. |
Content is already done and provided above @vpicone |
Here are the new svgs, there are screen grabs of where they go in the tables above. Status icons updatesCaution major colorsLight theme filled Caution major:
Dark theme filled Caution major:
Caution minor colorsLight theme filled Caution minor:
Dark theme filled Caution minor:
Status shape updatesCritical severity colorLight theme Critical severity:
Dark theme Critical severity:
High severity colorLight theme High severity:
Dark theme High severity:
Medium severity colorsLight theme High severity:
Dark theme High severity:
Low severity colorsLight theme Low severity:
Dark theme Low severity:
|
@vpicone here are the image updates names are the same so they should pop right in |
@jeanservaas need the token and usage content |
[pattern] status indicator fixes
Content issues:
The Security team pointed out that their guidance around data decorator components directly conflicts with some of what was in the shape status indicator guidance. Their shape status indicators are widely deployed in product and this discrepancy will cause confusion. Changing their shapes to conform to our guidance would also be very costly. We've decided to fold in their risk/severity scale shape indicators into our shape indicator lexicon as they are.
Security guidance links:
https://ibm.box.com/s/mb2dwp56k4rvgl50kwr9tniuqlpbpis7
https://ibm-security.carbondesignsystem.com/?path=/story/components-security-decorator--icons
To do:
@conradennis is helping us add two shapes to the library that we're currently missing (the 'Critical' right triangle' and the 'Low severity' square with a stroke for contrast accessibility)
feat(UI icons): new icons may and june carbon#8960
@vpicone we also need to update the warning major and warning minor assets for accessibility
We need to update the table content in the YAML file (I have content @vpicone if you open the PR and fix the tables, @jeanservaas can update the YAML in the issue)
@jeanservaas needs to update the attached images to reflect the real Security product UI (Including the legend image, it's an incorrect example of a legend).
Full new status shape table @cameroncalder for approval
- Images to fix:
The text was updated successfully, but these errors were encountered: